Control design and empty catch{} blocks
1. All code that is in the control should be reusable.
Please don't put anything specific to your pages in the control
For ex: Can gvTasks_RowDataBound, PopulateCaseGrid etc be reused by search too?
2. Three properties of _gvCases are already exposed as properties.
If you need to do more manipulation of _gvCases in your pages, please expose the whole grid and remove these properties
You can then directly work with the grid in your pages
(this is not good design but it's better than putting custom code in the control)
3. Please avoid empty catch{} blocks at all costs!
Like in gvTasks_RowDataBound
This is the most common way to have the code ignore bugs and cause unpredictable, difficult-to-track behavior.
Please don't put anything specific to your pages in the control
For ex: Can gvTasks_RowDataBound, PopulateCaseGrid etc be reused by search too?
2. Three properties of _gvCases are already exposed as properties.
If you need to do more manipulation of _gvCases in your pages, please expose the whole grid and remove these properties
You can then directly work with the grid in your pages
(this is not good design but it's better than putting custom code in the control)
3. Please avoid empty catch{} blocks at all costs!
Like in gvTasks_RowDataBound
This is the most common way to have the code ignore bugs and cause unpredictable, difficult-to-track behavior.
Comments
Post a Comment